Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 712fbe09-8920-4820-8cba-cd665d429179
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two moderate issues remain in the advertised portable fallback command.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Hardens portable Node runtime validation and improves repair fallback guidance.
Changes:
- Enforces ownership and real npm dry-run validation.
- Improves conditional fallback command generation.
- Updates tests, documentation, and changelog.
| File | Description |
|---|---|
test/fixlab-cli.test.js |
Adds regression assertions. |
scripts/repair-node-runtime.ps1 |
Strengthens runtime validation and ownership checks. |
scripts/install-fixlab.ps1 |
Adds portable fallback generation. |
docs/troubleshooting.md |
Documents validation and ownership requirements. |
docs/installation.md |
Documents strengthened repair guarantees. |
CHANGELOG.md |
Records the hardening changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 712fbe09-8920-4820-8cba-cd665d429179
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved dashboard lifecycle/control-record failures and a critical reparse-point ownership risk block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (2)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 712fbe09-8920-4820-8cba-cd665d429179
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 712fbe09-8920-4820-8cba-cd665d429179
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 712fbe09-8920-4820-8cba-cd665d429179
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
The portable Node repair could execute an existing unowned runtime during plan-only readiness checks, accept npm after only a version probe, and print unsafe or unusable PowerShell fallback guidance. Users also lacked a packaged way to stop a foreground dashboard from another terminal without manually identifying a Node process.
Change
npm.cmdand a realnpm pack --dry-run --ignore-scripts --jsonprobe for existing, extracted, and final runtimes.fixlab dashboard [repository] --stopusing an instance-specific local token and graceful loopback shutdown endpoint.Validation
npm pack --dry-runcontains the required filesnpm run validatepasses (92 unit tests and 8 Playwright tests)Risk
Low. Runtime changes add pre-install safety checks only. Dashboard shutdown accepts only a loopback request carrying the instance-specific token written by that dashboard. It never kills processes by name or PID and does not change permanent
PATH, NVM, or repository content.